From: Brion Vibber <brion@users.mediawiki.org>
Date: Tue, 4 Aug 2009 23:24:58 +0000 (+0000)
Subject: Add fixme note to replace 'mysql' command-line callout with proper usage of a second... 
X-Git-Tag: 1.31.0-rc.0~40501
X-Git-Url: http://git.cyclocoop.org/%22.%24info%5B?a=commitdiff_plain;h=4ac4b16f323e7a347f89baad87c819ceb2cda529;p=lhc%2Fweb%2Fwiklou.git

Add fixme note to replace 'mysql' command-line callout with proper usage of a second unbuffered DB connection
---

diff --git a/maintenance/populateSha1.php b/maintenance/populateSha1.php
index 4233cb2a10..72ef9461dd 100644
--- a/maintenance/populateSha1.php
+++ b/maintenance/populateSha1.php
@@ -56,6 +56,7 @@ class PopulateSha1 extends Maintenance {
 		$batch = array();
 	
 		if ( $method == 'pipe' ) {
+			// @fixme kill this and replace with a second unbuffered DB connection.
 			global $wgDBuser, $wgDBserver, $wgDBpassword, $wgDBname;
 			$cmd = 'mysql -u' . wfEscapeShellArg( $wgDBuser ) . 
 				' -h' . wfEscapeShellArg( $wgDBserver ) .